-
Notifications
You must be signed in to change notification settings - Fork 714
feat: support namespace arg for show mac #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yejianquan
merged 1 commit into
sonic-net:master
from
cyw233:support-namespace-for-show-mac
May 22, 2025
Merged
feat: support namespace arg for show mac #3873
yejianquan
merged 1 commit into
sonic-net:master
from
cyw233:support-namespace-for-show-mac
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
1b9feca
to
27461e7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
9d30bde
to
d34c95c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
d34c95c
to
a6731b2
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
a6731b2
to
498735c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
498735c
to
d5805f9
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick PR to 202505: #3893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the namespace support for
show mac
/fdbshow
command. For example, users can useshow mac -n asic0
orfbdshow -n asic0
.How I did it
How to verify it
Run
show mac -n asic0
orfdbshow -n asic0
and verify the outputPrevious command output (if the output of a command-line utility has changed)
Nothing has changed to the output of the
show mac
/fdbshow
command, we are only adding the namespace argument support in this PR. I confirmed the output ofsudo ip netns exec asicX show mac
andshow mac -n asicX
are the same.New command output (if the output of a command-line utility has changed)
Nothing has changed to the output of the
show mac
/fdbshow
command, we are only adding the namespace argument support in this PR. I confirmed the output ofsudo ip netns exec asicX show mac
andshow mac -n asicX
are the same.