Skip to content

feat: support namespace arg for show mac #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented May 5, 2025

What I did

Added the namespace support for show mac / fdbshow command. For example, users can use show mac -n asic0 or fbdshow -n asic0.

How I did it

How to verify it

Run show mac -n asic0 or fdbshow -n asic0 and verify the output

Previous command output (if the output of a command-line utility has changed)

Nothing has changed to the output of the show mac / fdbshow command, we are only adding the namespace argument support in this PR. I confirmed the output of sudo ip netns exec asicX show mac and show mac -n asicX are the same.

New command output (if the output of a command-line utility has changed)

Nothing has changed to the output of the show mac / fdbshow command, we are only adding the namespace argument support in this PR. I confirmed the output of sudo ip netns exec asicX show mac and show mac -n asicX are the same.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 force-pushed the support-namespace-for-show-mac branch from 1b9feca to 27461e7 Compare May 5, 2025 10:44
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 force-pushed the support-namespace-for-show-mac branch from 9d30bde to d34c95c Compare May 7, 2025 00:35
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 force-pushed the support-namespace-for-show-mac branch from d34c95c to a6731b2 Compare May 7, 2025 01:26
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 marked this pull request as ready for review May 7, 2025 02:04
@cyw233 cyw233 requested a review from abdosi May 8, 2025 01:35
@cyw233 cyw233 force-pushed the support-namespace-for-show-mac branch from a6731b2 to 498735c Compare May 18, 2025 23:38
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 force-pushed the support-namespace-for-show-mac branch from 498735c to d5805f9 Compare May 21, 2025 22:35
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 60110fa into sonic-net:master May 22, 2025
7 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #3893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants